[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pthread: work around winpthread header pollution on mingw

From: Eric Blake
Subject: Re: [PATCH] pthread: work around winpthread header pollution on mingw
Date: Thu, 23 Jan 2014 10:42:04 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 01/23/2014 02:44 AM, Pádraig Brady wrote:
> On 01/23/2014 05:38 AM, Eric Blake wrote:

>> +          [[#include <pthread.h>
>> +            #ifdef strtok_r
>> +            #error
>> +             break me
>> +            #endif
>> +          ]])],
>> +        [gl_cv_header_pthread_h_pollution=no],
>> +        [gl_cv_header_pthread_h_pollution=yes])])
> Would it be worth defining MINGW_PTHREAD_H_POLLUTION here
> for use as a guard for the undefs in pthread.in.h
> in case those were valid defines on some platform?
> I'm not suggesting just curious.

I don't see a reason for it at the present - unlike most replacement
headers that we build unconditionally, pthread.h is still one where the
replacement is only conditional.  We can revisit it if someone reports a

> Anyway the fix makes sense and looks good.

Thanks; I'll push it shortly.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]