bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: How to force using a module in Gnulib? (expl() on OpenBSD)


From: Assaf Gordon
Subject: Re: How to force using a module in Gnulib? (expl() on OpenBSD)
Date: Wed, 16 Apr 2014 11:44:42 -0400
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Hello,

On 04/15/2014 01:34 PM, Pádraig Brady wrote:
On 04/15/2014 05:18 PM, Assaf Gordon wrote:
+  dnl On some systems (OpenBSD5.4) the system's native expl() is buggy:
+  dnl it returns 'nan' for small values. This test compares expl() to exp() .

You might assume that fabs is in the same lib as expl?
So this FABS_LIBM var is probably best left out,
as it's not guaranteed set here.
<...>
Is checking this whole range necessary?
<...>
s/in/ion/
<...>
You could just move the whole block earlier in the function to line 55,
so that the subsequent check of $gl_cv_func_expl_in_libm etc. is significant?


Attached is an improved version, changed according to your suggestions.
It now uses Gnulib's expl on OpenBSD5.4, and the native expl on other systems.


Regards,
 -gordon


Attachment: m4_buggy_expl_2014_04_16.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]