[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: How to force using a module in Gnulib? (expl() on OpenBSD)

From: Pádraig Brady
Subject: Re: How to force using a module in Gnulib? (expl() on OpenBSD)
Date: Wed, 16 Apr 2014 17:54:26 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 04/16/2014 04:44 PM, Assaf Gordon wrote:
> Hello,
> On 04/15/2014 01:34 PM, Pádraig Brady wrote:
>> On 04/15/2014 05:18 PM, Assaf Gordon wrote:
>>> +  dnl On some systems (OpenBSD5.4) the system's native expl() is buggy:
>>> +  dnl it returns 'nan' for small values. This test compares expl() to 
>>> exp() .
>> You might assume that fabs is in the same lib as expl?
>> So this FABS_LIBM var is probably best left out,
>> as it's not guaranteed set here.
> <...>
>> Is checking this whole range necessary?
> <...>
>> s/in/ion/
> <...>
>> You could just move the whole block earlier in the function to line 55,
>> so that the subsequent check of $gl_cv_func_expl_in_libm etc. is significant?
> Attached is an improved version, changed according to your suggestions.
> It now uses Gnulib's expl on OpenBSD5.4, and the native expl on other systems.

Looks good.

I checked with:
  ./gnulib-tool --create-testdir --with-tests --test expl
and got this minor issue:
  checking checks whether expl is buggy...
  ../configure: line 9184: test: =: unary operator expected

I fixed that, removed the notice which seemed overkill in this context,
adjusted the Changelog, added some comments, fixed up the AC_CACHE_CHECK() 
and added a little texi info.

I'll push the attached later.


Attachment: expl-openbsd-nan.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]