[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check

From: Eric Blake
Subject: Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check
Date: Wed, 21 May 2014 14:08:50 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/21/2014 01:58 PM, Paul Eggert wrote:
> On 05/21/2014 11:54 AM, Kieran Colford wrote:
>> I definitely agree
>> with your suggestion of having a module put them in config.h
> Why config.h?  Can't it be put into a new include file, supplied by
> Gnulib?  stringops.h, say?We shouldn't bloat config.h unless we really
> need to.

Indeed, using a new header instead of bloating config.h ensures that
existing .c files in gnulib that already define their own STREQ won't
hit collisions (because they merely won't include the new file).

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]