[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Added a module stringops that provides STREQ and STRNEQ

From: Kieran Colford
Subject: Re: [PATCH] Added a module stringops that provides STREQ and STRNEQ
Date: Thu, 22 May 2014 01:05:29 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 14-05-22 12:54 AM, Paul Eggert wrote:
> Kieran Colford wrote:
>> I deliberately chose to use it as a macro and call it this because that
>> is how it is done everywhere else in gnulib.
> Sure, but let's take this opportunity to do a better API, while we're
> making a module for it.  So my suggestion would be to replace STREQ with
> streq uniformly elsewhere, after the stringops module is added.

One issue with making it streq rather than STREQ: there already exists
streq module (holding STREQ_OPT) and when a user is given a message from
``make syntax-check'' telling them to use streq, they will look to the
streq module.  If we intend to make the names so similar, then I think
it would be justified to merge the stringops module with the streq module.

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]