[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: test-getlogin false failure in non login shells

From: Pádraig Brady
Subject: Re: test-getlogin false failure in non login shells
Date: Thu, 22 May 2014 17:25:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 05/22/2014 04:39 PM, Tom G. Christensen wrote:
> On 19/05/14 14:37, Pádraig Brady wrote:
>> FYI I just pushed the attached to sync test-getlogin_r.c
>> with the recent changes in test-getlogin.c
> This broke the build on CentOS 6.
> depbase=`echo test-getlogin_r.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
>         gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -DGNULIB_STRICT_CHECKING=1 -I. 
> -I. -I.. -I./.. -I../gllib -I./../gllib   -g -O2 -Wall -MT test-getlogin_r.o 
> -MD -MP -MF $depbase.Tpo -c -o test-getlogin_r.o test-getlogin_r.c &&\
>         mv -f $depbase.Tpo $depbase.Po
> test-getlogin_r.c: In function 'main':
> test-getlogin_r.c:68: error: storage size of 'stat_buf' isn't known

Drats sorry. This shows up when the ttyname_r module is also used,
thus setting HAVE_TTYNAME (which I forgot to do), thus triggering
the invalid test code.

I've fixed this up in the attached and pushed.

sorry for the trouble.


Attachment: getlogin_r-test-fix.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]