[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] lib/rename.c: Conditionally define the out label

From: Paul Eggert
Subject: Re: [PATCH] lib/rename.c: Conditionally define the out label
Date: Sun, 01 Jun 2014 17:14:02 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Pádraig Brady wrote:
Well the ; is needed in C++ but optional in C.
I was worried about users leaving out the ; by mistake
and not noticing in the normal case of compiling in C.

But then the other case should be "# define _GL_UNUSED_LABEL ;", no? Otherwise a semicolon would be appended sometimes but not others, which cannot be right.

My experience is that macros whose expansion ends in ";" tend to cause confusion, so I'd rather omit the ";" in both cases. But if it's going to be added in the "if" it should also be added in the "else".

reply via email to

[Prev in Thread] Current Thread [Next in Thread]