Re: [PATCH] lib/rename.c: Conditionally define the out label

[Pádraig Brady]

On 06/02/2014 01:14 AM, Paul Eggert wrote:
> Pádraig Brady wrote:
>> Well the ; is needed in C++ but optional in C.
>> I was worried about users leaving out the ; by mistake
>> and not noticing in the normal case of compiling in C.
> 
> But then the other case should be "# define _GL_UNUSED_LABEL ;", no? 
> Otherwise a semicolon would be appended sometimes but not others, which 
> cannot be right.

Yes I should have added ; to the else

> My experience is that macros whose expansion ends in ";" tend to cause 
> confusion, so I'd rather omit the ";" in both cases.

Yes I agree, let's leave out the trailing ;

thanks,
Pádraig.