Re: [PATCH] lib/rename.c: rpl_rename - Avoid unused-but-set-variable compiler warning

[Paul Eggert]

On 06/02/2014 12:45 PM, Ben Walton wrote:
> The value is only referenced if RENAME_DEST_EXISTS_BUG is set. 
> Otherwise, it's set but never used again. This patch addresses the 
> case where RENAME_DEST_EXISTS_BUG is unset. Thanks -Ben 

Since that's not obvious, it might be a bit cleaner to have something 
like this instead:

# if RENAME_DEST_EXISTS_BUG
     bool dst_exists = false;
# endif

...

# if RENAME_DEST_EXISTS_BUG
      dst_exists = true;
# endif