[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#17773: AIX build errors with coreutils-8.22

From: Pádraig Brady
Subject: Re: bug#17773: AIX build errors with coreutils-8.22
Date: Sat, 14 Jun 2014 11:41:29 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 06/13/2014 11:07 PM, Paul Eggert wrote:
> Pádraig Brady wrote:
>> +     case "$host_os" in
>> +       aix* | freebsd*) CPPFLAGS="$CPPFLAGS -D_THREAD_SAFE" ;;
>> +       solaris*) CPPFLAGS="$CPPFLAGS -D_REENTRANT" ;;
> Why not use AC_DEFINE([_THREAD_SAFE], 1, ...) instead?  That makes for 
> shorter command lines in projects like Emacs.  I don't see any advantage to 
> putting it in CPPFLAGS.

Fair point. The reason that threadlib.m4 uses CPPFLAGS
is so that <pthread.h> is parseable on OSF/1.
But let's not try to cater for all old cases in the pthread module.
Also Bruno said that the existing pthread.h using code
in pthread.m4 works on (possibly newer) OSF/1:

So the attached patch is now completely independent of the threadlib module,
and uses AC_DEFINE.

I'll push later.


Attachment: gnulib-pthread-pthread-macros.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]