[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "localename" functions suggest pure/const attribute

From: Pádraig Brady
Subject: Re: "localename" functions suggest pure/const attribute
Date: Thu, 10 Jul 2014 19:48:59 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 07/10/2014 07:32 PM, Assaf Gordon wrote:
> On 07/10/2014 01:58 PM, Pádraig Brady wrote:
>> Oh I see now. That was more apparent from your initial patch:
>> http://lists.gnu.org/archive/html/bug-gnulib/2014-07/msg00038.html
>> (which I didn't get due to recent GNU mailing list issues).
>> I'll apply that.
> Regarding the patch I sent,
> I think the "pure" for "string_hash" is solid,
> but perhaps extra review is needed for the "const" for 
> "gl_locale_name_default" to ensure the wrapping macros are correct.

Right. The tag should be on the declaration.
I'm going with the attached. Tested with:

  new_flags='-Werror -Wsuggest-attribute=const -Wsuggest-attribute=pure'
  ./gnulib-tool --create-testdir --dir test.localename localename
  cd test.localename
  ./configure --quiet
  make AM_CFLAGS="$new_flags" -C gllib


Attachment: gnulib-localename-warnings.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]