[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix libunistring in MS-Windows locales

From: Daiki Ueno
Subject: Re: Fix libunistring in MS-Windows locales
Date: Thu, 17 Jul 2014 12:59:59 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> By the way, isn't there a minor race in gl_locale_name_thread, since it
>> depends on a global variable found_lcid?
> Yes.  (It is not a problem for Guile, since Guile built with threads
> on Windows is severely broken, so the only way of having a useful
> Guile on Windows is to build it without threads.)  Suggestions for
> fixing that are welcome.  Maybe just use the '__thread' qualifier for
> that variable?

I'm not familiar with Windows TLS support, but '__thread' seems to be
compiler specific.  Gnulib has glthread/tls but I'm not sure if it is
worth adding another dependency to localename.c (which is also shared
with libintl...) for this specific issue.

Maybe just lock around the use?

Daiki Ueno

reply via email to

[Prev in Thread] Current Thread [Next in Thread]