[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] obstack usability
|
From: |
Andreas Schwab |
|
Subject: |
Re: [PATCH 5/5] obstack usability |
|
Date: |
Sat, 26 Jul 2014 14:17:23 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.92 (gnu/linux) |
Paul Eggert <address@hidden> writes:
> On 07/26/2014 07:21 AM, Alan Modra wrote:
>>>> > >+# elif defined _MSC_VER && 1200 <= _MSC_VER
>>> >
>>> >Please write that as "_MSC_VER >= 1200".
>> Thanks for looking over the patch. This line was taken out of
>> gnulib/m4/gnulib-common.m4..
>>
>> I'm happy to fix this oddity and others like it,
> I'd rather leave this alone. This is a long-running disagreement about a
> minor style issue, and there's no need to impose the other style here.
This style is not suitable for high quality software.
Andreas.
--
Andreas Schwab, address@hidden
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
- Re: [PATCH] glibc 64-bit obstack support, (continued)
[PATCH 1/5] obstack tidy, Alan Modra, 2014/07/26
[PATCH 3/5] 64-bit obstack support, part 2, Alan Modra, 2014/07/26
[PATCH 5/5] obstack usability, Alan Modra, 2014/07/26
Re: [PATCH 5/5] obstack usability, Paul Eggert, 2014/07/26
[PATCH 4/5] 64-bit obstack support, part 3, Alan Modra, 2014/07/26
[PATCH 2/5] 64-bit obstack support, part 1, Alan Modra, 2014/07/26