[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] test-open: port to cygwin, which lacks Fortify

From: Eric Blake
Subject: Re: [PATCH] test-open: port to cygwin, which lacks Fortify
Date: Wed, 30 Jul 2014 20:59:03 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

On 07/30/2014 05:23 PM, Eric Blake wrote:
> On cygwin, with gcc 4.8.3, I get this compilation warning:
> In file included from ../../gltests/test-open.c:35:0:
> ../../gltests/test-open.h:35:1: warning: always_inline function might not be 
> inlinable [-Wattributes]
>  test_open (int (*func) (char const *, int, ...), bool print)
>  ^

> -#ifndef __always_inline
> -#define __always_inline
> +#if _LIBC && defined __always_inline

s/_LIBC/__GLIBC__/ (I picked the wrong witness macro; _LIBC is for
compiling glibc internally, while __GLIBC__ is when compiling with the
library).  After testing that it works both with and without
-D_FORTIFY_SOURCE=2 in CFLAGS, I'm pushing this.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]