bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] error: drop spurious semicolon


From: Eric Blake
Subject: [PATCH] error: drop spurious semicolon
Date: Thu, 4 Sep 2014 06:28:19 -0600

* lib/error.c (__error_at_line): Fix ';;'.

Signed-off-by: Eric Blake <address@hidden>
---

Pushing as trivial.

Noticed this while writing a syntax check rule to look for bogus
doubled semicolons.  If there's interest, I could add this rule
to maint.mk:

# Except for shell files and for loops, double semicolon is probably a mistake
sc_prohibit_double_semicolon:
        @prohibit=';;'                                          \
        in_vc_files='\.[ch]$$'                                  \
        exclude='for \(.*\)'                                    \
        halt="Double semicolon detected"                        \
          $(_sc_search_regexp)


 ChangeLog   | 5 +++++
 lib/error.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index b138dc2..dc88544 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-09-04  Eric Blake  <address@hidden>
+
+       error: drop spurious semicolon
+       * lib/error.c (__error_at_line): Fix ';;'.
+
 2014-09-02  Paul Eggert  <address@hidden>

        gnulib-common.m4: port to GCC 4.2.1 and Sun Studio 12 C++
diff --git a/lib/error.c b/lib/error.c
index 7b99cd7..18ff5db 100644
--- a/lib/error.c
+++ b/lib/error.c
@@ -75,7 +75,7 @@ extern void __error (int status, int errnum, const char 
*message, ...)
 extern void __error_at_line (int status, int errnum, const char *file_name,
                              unsigned int line_number, const char *message,
                              ...)
-     __attribute__ ((__format__ (__printf__, 5, 6)));;
+     __attribute__ ((__format__ (__printf__, 5, 6)));
 # define error __error
 # define error_at_line __error_at_line

-- 
1.9.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]