[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] poll: undef NOGDI
|
From: |
Marat Radchenko |
|
Subject: |
Re: [PATCH] poll: undef NOGDI |
|
Date: |
Tue, 30 Sep 2014 11:11:49 +0400 |
|
User-agent: |
Mutt/1.5.22 (2013-10-16) |
On Sun, Sep 28, 2014 at 09:43:01AM -0700, Ben Pfaff wrote:
> On Thu, Sep 18, 2014 at 04:53:37PM +0400, Marat Radchenko wrote:
> > On MinGW-W64, MsgWaitForMultipleObjects is guarded with #ifndef NOGDI.
> >
> > -DNOGDI=1 prevents inclusion of tons of Windows headers, especially
> > wingdi.h with weird #define ERROR 0 that has high chances to conflict
> > with internal software defines. So, just #undef NOGDI.
> >
> > MinGW-W64 bug: http://sourceforge.net/p/mingw-w64/bugs/397/
> > When it is fixed, this commit can be reverted.
>
> According to that URL, this bug has already been fixed, so it seems that
> this is not worth applying at all?
After thinking for a while, I think you're right. I'll just wait for next
MinGW-W64 release.