[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: compilation warning in error.c

From: Paul Eggert
Subject: Re: compilation warning in error.c
Date: Wed, 05 Nov 2014 00:14:47 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

Werner LEMBERG wrote
  #if _LIBC
-  __fxprintf (NULL, file_name != NULL ? "%s:%d: " : " ",
-              file_name, line_number);
+  if (file_name != NULL)
+    __fxprintf (NULL, "%s:%d: ", file_name, line_number);
+  else
+    __fxprintf (NULL, " ");

The new version is less efficient because it contains more instructions, no? And the old version is correct. So my guess is that the patch wouldn't be accepted upstream.

How about if we call the warning a compiler bug instead? You can file a bug report with the GCC folks....

reply via email to

[Prev in Thread] Current Thread [Next in Thread]