[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

From: Paul Eggert
Subject: Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC
Date: Sun, 30 Nov 2014 14:59:53 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

KO Myung-Hun wrote:
* lib/fdopendir.c (fdopendir): Implement on OS/2 kLIBC.

Patches from coreutils 8.8 by Paul Smedley.

First, we don't have copyright assignment from Paul Smedley, so we can't install the patch without having that cleared up one way or another.

Second, the patch seems to introduce a lot of code that's duplicated from existing code. It really should be rewritten to minimize the duplication.

I don't know what problem the patch is trying to solve; this should be made clear in the comments somewhere.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]