[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/21] gnulib-tool: disable a symbolic link on OS/2

From: KO Myung-Hun
Subject: Re: [PATCH 01/21] gnulib-tool: disable a symbolic link on OS/2
Date: Tue, 02 Dec 2014 12:44:56 +0900
User-agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2


Paul Eggert wrote:
> KO Myung-Hun wrote:
>> +# OS/2 does not support a symbolc link at all
>> +case `uname -s` in
>> +  "OS/2") no_symlink_support=true;;
>> +  *) no_symlink_support=;;
>> +esac
> Surely it would be better to test this directly, by running 'ln -s' and
> seeing it fail, than to look at operating system names.


> 'symbolc' is misspelled.

I'll fix.

> gnulib-tool uses 'true' and 'false' for boolean flags.  See, e.g.,
> 'have_associative'.
> Use a positive flag 'have_symlinks' rather than a negative flag
> 'no_symlink_support'; that's less confusing and uses the existing naming
> convention better.


> If symbolic links are not available, it's better for 'gnulib-tool
> --symbolic' to quickly fail instead of quietly succeed without using
> symbolic links.

Instead, how about warning that --symbolic is not supported, instead
copy will be used ?

KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

reply via email to

[Prev in Thread] Current Thread [Next in Thread]