Re: [PATCH 01/21] gnulib-tool: disable a symbolic link on OS/2

[KO Myung-Hun]

Hi/2.

Paul Eggert wrote:
> KO Myung-Hun wrote:
>> +# OS/2 does not support a symbolc link at all
>> +case `uname -s` in
>> +  "OS/2") no_symlink_support=true;;
>> +  *) no_symlink_support=;;
>> +esac
> 
> Surely it would be better to test this directly, by running 'ln -s' and
> seeing it fail, than to look at operating system names.
> 

Ok.

> 'symbolc' is misspelled.
> 

I'll fix.

> gnulib-tool uses 'true' and 'false' for boolean flags.  See, e.g.,
> 'have_associative'.
> 
> Use a positive flag 'have_symlinks' rather than a negative flag
> 'no_symlink_support'; that's less confusing and uses the existing naming
> convention better.
> 

Ok.

> If symbolic links are not available, it's better for 'gnulib-tool
> --symbolic' to quickly fail instead of quietly succeed without using
> symbolic links.

Instead, how about warning that --symbolic is not supported, instead
copy will be used ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr