Re: [PATCH 20/21] fdopendir: port to OS/2 kLIBC

[KO Myung-Hun]

Hi/2.

Paul Eggert wrote:
> KO Myung-Hun wrote:
>> * lib/fdopendir.c (fdopendir): Implement on OS/2 kLIBC.
>>
>> Patches from coreutils 8.8 by Paul Smedley.
> 
> First, we don't have copyright assignment from Paul Smedley, so we can't
> install the patch without having that cleared up one way or another.
> 

Which ways ?

> Second, the patch seems to introduce a lot of code that's duplicated
> from existing code.  It really should be rewritten to minimize the
> duplication.
> 

I'll try.

> I don't know what problem the patch is trying to solve; this should be
> made clear in the comments somewhere.

Essential problem is that dup() does not work on fd for a directory.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr