[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/21] Workaround for dirfd() on OS/2 kLIBC
From: |
KO Myung-Hun |
Subject: |
Re: [PATCH 18/21] Workaround for dirfd() on OS/2 kLIBC |
Date: |
Tue, 02 Dec 2014 22:17:23 +0900 |
User-agent: |
Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 |
Hi/2.
Paul Eggert wrote:
> KO Myung-Hun wrote:
>> * lib/fts.c (fts_build): Do not check dir_fd on OS/2 kLIBC.
>
> I'm afraid this change needs more explanation. If the problem is that
> dirfd returns -2, the earlier part of fts_build will return when that
> happens, so that problem cannot be fixed by the patch that you sent.
>
First of all, sorry. I've misread codes. Essential problem is that kLIBC
dup() does not work on a directory fd. So this patch tries to use a path
instead of fd.
And dirfd() always returns -2 as I said before. But dirfd() is executed
only if continue_readdir is true.
> What actually goes wrong if the change is omitted?
For examples, rm -rf fails like this.
-----
rm.exe: traversal failed: 'g:\\ex\\t': Bad file number
-----
--
KO Myung-Hun
Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
Korean OS/2 User Community : http://www.ecomstation.co.kr
- Re: [PATCH 18/21] Workaround for dirfd() on OS/2 kLIBC,
KO Myung-Hun <=