[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/21] find_executable: port to EMX

From: Bruno Haible
Subject: Re: [PATCH 07/21] find_executable: port to EMX
Date: Tue, 02 Dec 2014 17:23:07 +0100
User-agent: KMail/4.8.5 (Linux/3.2.0-64-generic; KDE/4.8.5; x86_64; ; )

KO Myung-Hun wrote:
> BTW, do you mean to put URL into a source as a comment ?

Yes, this is what I mean. Rationale: Most gnulib developers don't
have this reference handy, and a Google search did not provide
the URL that you found.

> > Reliability: Please don't ignore the return value of DosGetInfoBlocks.
> > 
> DosGetInfoBlocks() returns no values.

Well, the URL that you showed describes its return value as
"APIRET    ulrc;   /*  Return Code. */"

And the code in http://dennisdarland.com/russell_doc/html/os__dep_8c-source.html
and in http://cpansearch.perl.org/src/JHI/perl-5.7.1/os2/OS2/Process/Process.xs
do check the return value.

And http://www.gladir.com/CODER/COS2/dosgetinfoblocks.htm
describes that a return value == NO_ERROR means success.

Even when (or especially when) you don't know under which conditions a
system function can fail, you should check its return value. Code that
does not follow this policy becomes unreliable and undebuggable, in the long


reply via email to

[Prev in Thread] Current Thread [Next in Thread]