[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/21] spawn: do not include sched.h on OS/2 kLIBC
From: |
KO Myung-Hun |
Subject: |
Re: [PATCH 05/21] spawn: do not include sched.h on OS/2 kLIBC |
Date: |
Thu, 04 Dec 2014 10:03:34 +0900 |
User-agent: |
Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 |
Bruno Haible wrote:
> KO Myung-Hun posted:
>> 0001-sched-check-struct-sched_param-in-spawn.h-as-well.patch
>
> Thanks. This looks much better now. Just two small improvements I'd like
> to ask for:
>
> - In m4/sched_h.m4, can you bump the marker "sched_h.m4 serial 6"
> to "sched_h.m4 serial 7"?
>
No problem.
> - In lib/sched.in.h: We try to put all #includes before all type definitions
> and variable/function declarations. (Otherwise the overriding of function
> declarations may not work well in the long run.) Can you move the
> #ifdef ... / # include <spawn.h>
> near the #include <sys/types.h>, that is, before the
> #if address@hidden@
>
Like this ?
--
KO Myung-Hun
Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
Korean OS/2 User Community : http://www.ecomstation.co.kr
0001-sched-check-struct-sched_param-in-spawn.h-as-well.patch
Description: Text document