[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 12/21] pipe_filter_ii_execute: port to OS/2 kLIBC

From: Bruno Haible
Subject: Re: [PATCH 12/21] pipe_filter_ii_execute: port to OS/2 kLIBC
Date: Thu, 04 Dec 2014 12:09:54 +0100
User-agent: KMail/4.8.5 (Linux/3.2.0-64-generic; KDE/4.8.5; x86_64; ; )

KO Myung-Hun:
> >> * lib/pipe-filter-ii.c (start_wrapper, _beginthreadex, CloseHandle,
> >> WaiForSingleObject, WaitForMultipleObjects): New on OS/2 kLIBC.
> > 
> > Since you make use of these functions in w32spawn.h, their implementation
> > does not belong in pipe-filter-ii.c, but rather in some other .c file,
> > say w32-on-os2.c.
> > 
> They are used only for pipe-filter-ii.c. w32spawn.h is used to use
> Windows codes of spawn-pipe module.
> Still should I generates separate files ?

There are multiple reasons to put the implementation of these functions
in a file different from pipe-filter-ii.c:
  - _beginthreadex is also used in pipe-filter-gi.c.
  - WaitForSingleObject is also used in poll.c.
  - These functions are implementations of Windows library API on top of
    kLIBC API. Something different than just the implementation of

w32spawn.h is the layer that implements "auxiliary functions for the
creation of subprocesses", based on the Windows API.

The functions here are an implementation of Windows API on top of kLIBC
API. Therefore it does not belong in w32spawn.h, but rather in a different
file w32-on-os2.{h,c}.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]