Re: [PATCH 02/14] Fix character encoding aliases for OS/2

[Daiki Ueno]

Hello,

The change should work, but I have a feeling that something is wrong:

> +# if defined OS2
> +      /* To avoid the troubles of installing a separate file in the same
> +         directory as the DLL and of retrieving the DLL's directory at
> +         runtime, simply inline the aliases here.  */
> +
> +      cp = "bg_BG" "\0" "CP1251" "\0"

You are adding locale-to-charset mappings here, while all other mappings
defined are charset-to-charset.  Perhaps such a mappings could be
resolved in intl/localealias.c through the locale.alias file instead?

Your change might be necessary for other consumers than gettext.  If so,
could you explain the actual use-case in the ChangeLog and/or the above
comment?

Also if it changes anything in the OS/2 port of gettext, consider
updating this file:
http://git.savannah.gnu.org/cgit/gettext.git/tree/os2/README.OS2

Thanks,
--
Daiki Ueno