bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] chdir-long: avoid -Werror=unused-variable with -DNDEBUG


From: Paul Eggert
Subject: Re: [PATCH] chdir-long: avoid -Werror=unused-variable with -DNDEBUG
Date: Sat, 20 Dec 2014 13:03:23 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0

Norihiro Tanaka wrote:
+#if NDEBUG
+      close (cdb->fd);
+#else
        bool close_fail = close (cdb->fd);
        assert (! close_fail);
+#endif

That sort of thing looks like it'd be reasonably annoying in the long run. How about the attached patch instead?

Attachment: 0001-assure-new-module.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]