[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/11] Android compatibility

From: Paul Eggert
Subject: Re: [PATCH 00/11] Android compatibility
Date: Tue, 17 Feb 2015 22:07:38 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

Kevin Cernekee wrote:
test-localename is calling strdup() on a NULL pointer returned by
>>gl_locale_name_thread(), and crashing.  From reading
>>gl_locale_name_thread() it seems like NULL is a valid result.  Maybe we
>>need to change the test case to "return 77" on systems that are unaware
>>of locales?
>Yes, that sounds right.  Can you propose a patch along those lines?
OK.  Should I just check for NULL, or is there a better test that
would indicate that the locale support is completely absent?

I haven't read that part of the code, but it sounds like a NULL test would be good enough.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]