Re: [PATCH 2/3] getdtablesize: Extend RLIMIT_NOFILE fallback case to Android

[Kevin Cernekee]

On Wed, Feb 18, 2015 at 11:30 PM, Paul Eggert <address@hidden> wrote:
> Kevin Cernekee wrote:
>>
>> The changes to the AC_RUN_IFELSE test programs do not have an effect
>> on Android since we are cross-compiling:
>>
>>      checking whether dup2 works... guessing no
>>      [...]
>>      checking whether fcntl handles F_DUPFD correctly... guessing no
>
>
> How about if we stop guessing no on Android when cross-compiling?  Does the
> attached patch (which I installed) fix things for you?

dup2 is guessed correctly:

    checking whether dup2 works... guessing yes

F_DUPFD is not, due to a minor C&P error (patch attached):

    checking whether fcntl handles F_DUPFD correctly...
    checking whether fcntl understands F_DUPFD_CLOEXEC... needs runtime check

However, I don't see how any of the m4 changes address the problem
that is causing the test cases to fail: lib/getdtablesize.c still
wants to rely on sysconf(_SC_OPEN_MAX) on Android, and that call just
blindly returns 256 on all released versions of the OS.  This is why
my earlier submission changed it to use getrlimit() instead.

0001-fcntl-Fix-cross-compiling.patch
Description: Text Data