[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils + maint.mk + public-submodule-commit

From: Eric Blake
Subject: Re: coreutils + maint.mk + public-submodule-commit
Date: Thu, 09 Apr 2015 12:24:49 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 04/09/2015 12:20 PM, Andreas Grünbacher wrote:
> 2015-04-09 19:08 GMT+02:00 Eric Blake <address@hidden>:
>> Maybe 'make check' is the wrong time, and a 'git push'
>> hook is the better place to be doing it.  But we DO want to prevent
>> pushing a patch upstream to the public repo that relies on a submodule
>> commit that is not public, as anything else is not nice to clean up after.
> Sounds like the Savannah server should be be checking that for all
> its projects that use gnulib.

I don't have access rights to savannah to install such a hook, but yes,
having a server-side hook instead of trying to enforce client-side hooks
would be a reasonable solution. Does anyone have an example hook that we
could tell savannah admins to install on all git projects that have a
submodule, where it would refuse incoming pull requests that update the
submodule to a non-public commit?

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]