[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] git-version-gen: detect untagged revisions

From: Mats Erik Andersson
Subject: Re: [PATCH] git-version-gen: detect untagged revisions
Date: Wed, 15 Apr 2015 00:01:12 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

Hello again,

Tuesday den 14 April 2015 klockan 21:34 skrev Pádraig Brady detta:
> On 14/04/15 19:43, Mats Erik Andersson wrote:
> > 
> > This has to be undone, as it breaks 'make dist' due to
> > the incomplete (misbehaving?) file 'top/GNUMakefile'.
> > There is no problem with a shallow clone, but a corner
> > case exists with annotated tags.
> Done,

Thank you! Let me add some more information for the record,
shedding light on an interdependency I did not observe.

Before my change, the build daemon at Hydra would execute
'make dist' and immediately issue

  WARNING: unable to verify is the correct version

With my patch, the corresponding message became

  INFO: running autoreconf for a new version string: \

Our most recent annotated tag is "inetutils-1_9_2", so the prepended
character 'g' is due to me and the rest is due to the lack of the
sed script 's|inetutils-|v|; s|_|.|g'.

The warning above is 'top/GNUMakefile' announcing that it accepts
a claimed revision string, and in fact this decision is solely due
to a very sneeky/cunning use of "UNKNOWN":

    ### top/GNUMakefile: line 58 -- 61
    ifneq ($(_curr-ver),$(VERSION))
      ifeq ($(_curr-ver),UNKNOWN)
        $(info WARNING: unable to verify ...)

My solution tried to resolve "UNKNOWN" into something better, but
this code snippet caught me in an unforeseen trap. Any effort to
expand 'git-version-gen' must seemeing change also this part.

I hope to refine my idea into something less risky, now that a
mechanism behind the first failure is at hand. Time will tell!

Best regards,
  Mats Erik Andersson

reply via email to

[Prev in Thread] Current Thread [Next in Thread]