bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] stdio: fix probe on mingw under gcc 5.1


From: Paul Eggert
Subject: Re: [PATCH] stdio: fix probe on mingw under gcc 5.1
Date: Wed, 20 May 2015 20:40:35 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

$EGREP has undefined behavior on binary data, so this isn't portable.

I long ago gave up on AC_EGREP_CPP, since it's too flaky nowadays. Why can't we test directly for what we're worried about? I'm afraid I am not following why the value of PRIdMAX is related to whether printf should use the __gnu_printf__ or the __printf__ attribute.

By "test directly" I mean compile a little test program with printf and see whether GCC warns about misuse. By seeing what GCC warns about and what it doesn't we should be able to figure out which attribute is appropriate.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]