[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/12] gnulib-tool: fall back into copy if symbolic link is n
|
From: |
KO Myung-Hun |
|
Subject: |
Re: [PATCH 06/12] gnulib-tool: fall back into copy if symbolic link is not supported |
|
Date: |
Fri, 29 May 2015 11:34:35 +0900 |
|
User-agent: |
Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 |
Hi/2.
Paul Eggert wrote:
> KO Myung-Hun wrote:
>
>> +# Check if symbolic link is supported
>> +have_symlink_support=false
>> +rm -f symlink$$.file symlink$$
>> +if (echo >symlink$$.file) 2>/dev/null; then
>> + if ln -s symlink$$.file symlink$$ 2>/dev/null; then
>> + have_symlink_support=true
>> + fi
>> +fi
>> +rm -f symlink$$.file symlink$$
>
> There's no need to use the echo; just use ln -s (the target need not
> exist).
>
> Also, this test should be done dynamically, when the actual ln -s is
> run, not at the start of the run. That is because 'ln -s' might succeed
> on some file systems but not on others. It's OK to output a warning for
> the first ln -s that
> is replaced by a cp, but I wouldn't warn for each one.
>
How about this ?
--
KO Myung-Hun
Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
Korean OS/2 User Community : http://www.ecomstation.co.kr
0001-gnulib-tool-fall-back-into-copy-if-symbolic-link-is-.patch
Description: Text document
- [PATCH 02/12] binary-io: don't put fd in binary mode if it is a console on EMX, (continued)
- [PATCH 02/12] binary-io: don't put fd in binary mode if it is a console on EMX, KO Myung-Hun, 2015/05/27
- [PATCH 03/12] pipe-filter-aux: undefine HAVE_SELECT on KLIBC, KO Myung-Hun, 2015/05/27
- [PATCH 05/12] wcwidth: fix 'conflicting types' error for `__wcwidth' on OS/2 kLIBC, KO Myung-Hun, 2015/05/27
- [PATCH 04/12] w32spawn: clear SHELL_SPECIAL_CHARS and SHELL_SPACE_CHAR on OS/2 kLIBC, KO Myung-Hun, 2015/05/27
- [PATCH 06/12] gnulib-tool: fall back into copy if symbolic link is not supported, KO Myung-Hun, 2015/05/27
- Re: [PATCH 06/12] gnulib-tool: fall back into copy if symbolic link is not supported, Paul Eggert, 2015/05/27
[PATCH 07/12] pipe_filter_ii_execute: port to OS/2 kLIBC, KO Myung-Hun, 2015/05/27
[PATCH 08/12] dup, dup2, fcntl: support a directory fd on OS/2 kLIBC, KO Myung-Hun, 2015/05/27
[PATCH 09/12] opendir, closedir, dirfd, fdopendir: port to OS/2 kLIBC, KO Myung-Hun, 2015/05/27
[PATCH 10/12] configmake: prepend /@unixroot on OS/2 kLIBC, KO Myung-Hun, 2015/05/27
[PATCH 11/12] utimes: detect utimes() correctly on OS/2 kLIBC, KO Myung-Hun, 2015/05/27