[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bootstrap bug with wrapped lines?
From: |
Pádraig Brady |
Subject: |
Re: Bootstrap bug with wrapped lines? |
Date: |
Tue, 02 Jun 2015 16:45:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 02/06/15 16:32, Andreas Grünbacher wrote:
> I'm running into a problem with the acl-permissions module, which
> contains the following
> Makefile snippet:
>
> lib_SOURCES += acl-errno-valid.c acl-internal.c \
> get-permissions.c set-permissions.c
>
> This ends up as follows in Makefile.in in coreutils (line
> wrapping changed for brevity):
>
> am__lib_libcoreutils_a_SOURCES_DIST = [...] \
> lib/acl-errno-valid.c lib/acl-internal.c \
> get-permissions.c set-permissions.c \
> [...]
>
> In other words, only the lib_SOURCES files on the first line are
> correctly prefixed with lib/.
> The following change makes the problem go away:
>
> diff --git a/modules/acl-permissions b/modules/acl-permissions
> index 49b91ff..5c82c4b 100644
> --- a/modules/acl-permissions
> +++ b/modules/acl-permissions
> @@ -21,8 +21,7 @@ configure.ac:
> gl_FUNC_ACL
>
> Makefile.am:
> -lib_SOURCES += acl-errno-valid.c acl-internal.c \
> - get-permissions.c set-permissions.c
> +lib_SOURCES += acl-errno-valid.c acl-internal.c get-permissions.c
> set-permissions.c
>
> Include:
> "acl.h"
>
> In addition to acl-permissions, the argp and inttostr modules are
> using multiline lib_SOURCES directives.
>
> How should this be fixed?
I think this should be fixed already with:
http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=e3704b9c
Can you checkout the latest coreutils and rerun:
./bootstrap && ./configure --quiet ...
cheers,
Pádraig.