[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xalloc: avoid GCC 5.1 warning on 32 bit

From: Paul Eggert
Subject: Re: [PATCH] xalloc: avoid GCC 5.1 warning on 32 bit
Date: Sat, 3 Oct 2015 00:39:00 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

Pádraig Brady wrote:
xalloc is
included into the coreutils compilation units and so
needs this guard.

That's a problem in coreutils, not in gnulib. Please don't give much weight to those particular compiler warnings. They're often false alarms, as these were. There is nothing wrong when a compiler can reason about integer overflow to generate better code. Conversely, it is often helpful for an application to use signed integer types so that a checking implementation can report integer overflow when the appliction is buggy, which means we shouldn't blindly substitute unsigned for signed types merely to stop GCC from bleating in this way.

I reverted the gnulib change, and installed the attached coreutils patches to pacify 32-bit GCC in a better way. If these sorts of warnings continue to be a hassle in coreutils, perhaps we should disable the warnings there too.

Attachment: 0001-build-Pacify-GCC-5-on-32-bit-hosts.patch
Description: Text document

Attachment: 0002-build-update-gnulib-submodule-to-latest.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]