[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnul

From: Paul Eggert
Subject: Re: [PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnul
Date: Sun, 18 Oct 2015 10:28:12 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

Jim Meyering wrote:
Building coreutils configured with --enable-gcc-warnings and using
bleeding-edge gcc evoked a build failure due to the time_rz module.
The attached patch removes the warning/error-evoking test.

This patch doesn't look right: if localtime_r fails, the original code returns NULL, but the revised code does not. I installed the attached further patch which fixes that, and which attempts to work around the compiler warning (though I can't easily test that).

Attachment: 0001-time_rz-return-NULL-if-localtime_r-fails.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]