[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: a ChangeLog typo and two sc_tight_scope fixes

From: Pádraig Brady
Subject: Re: a ChangeLog typo and two sc_tight_scope fixes
Date: Sun, 18 Oct 2015 22:33:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 18/10/15 05:04, Jim Meyering wrote:
> I've just pushed the following three patches:

Nice. Note this improvement triggered new
syntax check failures on coreutils

  $ make sc_tight_scope

That's because the gnulib rule was working on an
invalid blank regular expression extracted from SOURCES,
thus effectively being ignored, as it was matching all
extern functions found with nm. with your added ^_?$
around the expression, this no longer happened, thus
triggering the above valid issues.

I've sent a patch to coreutils to fix those,
and the attached gnulib patch is not strictly required
after your improvements, though it does remove some
extraneous unlikely to match expressions.


Attachment: tight_scope-extra-matches.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]