bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 08/11] openat_proc_name: port to OS/2 kLIBC


From: KO Myung-Hun
Subject: Re: [PATCH v7 08/11] openat_proc_name: port to OS/2 kLIBC
Date: Fri, 15 Jan 2016 11:11:29 +0900
User-agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2

Hi/2.

Paul Eggert wrote:
> On 01/13/2016 06:23 PM, KO Myung-Hun wrote:
> 
>> +    if (__libc_Back_ioFHToPath (fd, path, sizeof (path)))
> 
> Don't parenthesize the argument of sizeof here.
> 
>> +    sprintf (result, "%s/%s", path, file);
> 
> This won't work if PATH or FILE is longer than INT_MAX bytes. Please
> just use memcpy or strcpy instead.

Updated.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

Attachment: 0001-openat_proc_name-port-to-OS-2-kLIBC.patch
Description: Source code patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]