Re: [PATCH 1/2] test-framework-sh: port to NetBSD 7.0

[Jim Meyering]

On Fri, Mar 25, 2016 at 12:20 AM, Paul Eggert <address@hidden> wrote:
> Problem reported by Assaf Gordon in: http://bugs.gnu.org/23107#13
> * tests/init.sh (testdir_prefix_, pfx_, template_length_):
> Remove.  All uses removed.
> (test_dir_): Adjust to mktempd_ change.
> (mktempd_): Omit 2nd arg.  Stop using -t, as it is not portable.
> (base_template_, template_, nx_): Simplify by hardcoding.
> ---
>  ChangeLog     | 10 ++++++++++
>  tests/init.sh | 37 +++++++++++--------------------------
>  2 files changed, 21 insertions(+), 26 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 74e0906..8ddd59b 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,13 @@
> +2016-03-24  Paul Eggert  <address@hidden>
> +
> +       test-framework-sh: port to NetBSD 7.0
> +       Problem reported by Assaf Gordon in: http://bugs.gnu.org/23107#13
> +       * tests/init.sh (testdir_prefix_, pfx_, template_length_):
> +       Remove.  All uses removed.
> +       (test_dir_): Adjust to mktempd_ change.
> +       (mktempd_): Omit 2nd arg.  Stop using -t, as it is not portable.
> +       (base_template_, template_, nx_): Simplify by hardcoding.
> +

Hi Paul,

I know that mktemp's -t is not portable, but the code in
init.sh was supposed to work around that. Did you see
some place where that work-around failed?

I did see the use of mktemp's -t in gzip's zdiff script
caused trouble, but did not see a problem in any use
from init.sh.  In the latter, it falls back to generating
the name manually.  And besides, I really do find it
a lot more useful when each temporary test directory
name includes the name of the test for which it was created.