[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problem with sys_select on Cygwin

From: Paul Eggert
Subject: Re: Problem with sys_select on Cygwin
Date: Tue, 29 Mar 2016 18:10:38 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1

On 03/29/2016 07:00 AM, Ken Brown wrote:
-   name" problems on Cygwin.
+   name" problems on newlib systems..

No double '..'; and maybe the comment could say "newlib systems,
including Cygwin", since that is our most common newlib system.

Otherwise, I'm okay with the change.

Could someone install this change (assuming there's no objection)?

The ifdef says 'defined __CYGWIN__' and this matches the comment. All other Gnulib comments talk about Cygwin not newlib, and it'd be confusing to make a special distinction only here.

I suppose that if this code is newlib-specific, not Cygwin-specific, it should use 'defined __NEWLIB__' and then the comment should be changed as you suggest. But in that case, what other uses of __CYGWIN__ should be changed to __NEWLIB__? There are quite a few uses of __CYGWIN__, and I don't know which of them apply just to Cygwin and which apply to newlib in general.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]