Re: Problem with sys_select on Cygwin

[Paul Eggert]

On 03/29/2016 07:00 AM, Ken Brown wrote:
> > > -   name" problems on Cygwin.
> > > +   name" problems on newlib systems..
> >
> > No double '..'; and maybe the comment could say "newlib systems,
> > including Cygwin", since that is our most common newlib system.
> >
> > Otherwise, I'm okay with the change.
>
> Could someone install this change (assuming there's no objection)? 

The ifdef says 'defined __CYGWIN__' and this matches the comment. All 
other Gnulib comments talk about Cygwin not newlib, and it'd be 
confusing to make a special distinction only here.

I suppose that if this code is newlib-specific, not Cygwin-specific, it 
should use 'defined __NEWLIB__' and then the comment should be changed 
as you suggest. But in that case, what other uses of __CYGWIN__ should 
be changed to __NEWLIB__? There are quite a few uses of __CYGWIN__, and 
I don't know which of them apply just to Cygwin and which apply to 
newlib in general.