[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mountlist/ptsname_r: leverage AC_HEADER_MAJOR
|
From: |
Dmitry V. Levin |
|
Subject: |
Re: [PATCH] mountlist/ptsname_r: leverage AC_HEADER_MAJOR |
|
Date: |
Sat, 16 Apr 2016 16:20:27 +0300 |
On Sat, Apr 16, 2016 at 01:20:32PM +0100, Pádraig Brady wrote:
> On 16/04/16 11:51, Bruno Haible wrote:
> >Hi Mike,
> >
> >>These two modules use makedev/major/minor but don't have explicit
> >>checks for the functions. Use the existing autoconf macro which
> >>will probe some headers for use and set up some defines.
> >
> >Does this change fix a compilation problem? You did not say so.
>
> Context in
> http://lists.gnu.org/archive/html/bug-gnulib/2016-03/msg00025.html
> glibc-2.23 and musl now need this change it seems.
>
> I suggested a makedev gnulib module in the thread above
> as it's not just the headers that are varying,
> as also some systems use mkdev() and some makedev().
>
> The patch should be fine to apply though and fixes an immediate issue.
Only mountlist part of the patch is relevant, the ptsname_r part is not
needed.
--
ldv
pgpXxdBrMKy3p.pgp
Description: PGP signature