[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Make git-version-gen compatible with dash shell

From: Paul Eggert
Subject: Re: Make git-version-gen compatible with dash shell
Date: Sun, 8 May 2016 11:42:19 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2

Mosè Giordano wrote:
> Without the patch I get a
>     shift: can't shift that many
> error.

Thanks. It's preferable to get an error, since callers should not pass --prefix
without an argument operand. However, the shell script should not be relying on
undefined behavior to report the error. I installed the attached patch, which
should fix that.

Attachment: 0001-git-version-gen-avoid-undefined-shift.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]