[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] use AM_TESTS_ENVIRONMENT Automake variable

From: Mathieu Lirzin
Subject: Re: [PATCH 0/2] use AM_TESTS_ENVIRONMENT Automake variable
Date: Mon, 04 Jul 2016 23:09:20 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)


Pádraig Brady <address@hidden> writes:

> On 02/07/16 20:50, Mathieu Lirzin wrote:
>> ping
>> Mathieu Lirzin <address@hidden> writes:
>>> Hello,
>>> Since 2011 Automake TESTS_ENVIRONMENT variable is reserved for the
>>> user unless the “older (and discouraged) serial test harness” is used.
>>> See:
>>> https://www.gnu.org/software/automake/manual/automake.html#index-AM_005fTESTS_005fENVIRONMENT
>>> The first patch makes use of the new AM_TESTS_ENVIRONMENT
>>> developer-reserved variable, and the second one adds a ‘syntax-check’
>>> to ensure no rule to preach the good news!  ;)
>>> Thanks,
> The patch looks correct but what about backwards compat?
> The DEPENDENCIES files lists automake 1.9.6 (2005) as a dependency.
> Should we increase that? Maybe.
> Should we increase that for this? Probably not.

Automake is a dependency that only matters to developpers.  Since Debian
stable has a more recent version and RHEL 7 has one too (I guess),
requiring Automake 1.12 (2012) seems reasonable to me.  WDYT?

Thanks for the review.

Mathieu Lirzin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]