Re: [PATCH v2 0/4] New getprogname module

[Jim Meyering]

On Wed, Sep 7, 2016 at 10:22 AM, Gisle Vanem <address@hidden> wrote:
> Jim Meyering wrote:
>
>> +# elif HAVE_DECL___ARGV
>> +  return last_component (__argv);
>
> This should be:
>   return last_component (*__argv);
>
> Or with a bit more care:
>   if (*__argv == NULL)
>      return ("?");
>   return last_component (__argv);

Thanks!
I fixed that and the copy/paste error mentioned below with a patch in
your name. Will push after you ACK.

> And in the test:
>
> +int
> +main (void)
> +{
> +  char const *p = getprogname ();
> +  assert (STREQ (p, "test-getprogname"));
> +  return 0;
> +}
>
>
> getprogname() would return "test-getprogname.exe" on
> Windows. Hence a fail.

I've fixed that with a separate patch to make it use EXEEXT.

> BTW, what is 'base' used for here:
>
> # elif HAVE_GETEXECNAME
>   const char *base = getexecname ();
>   if (!base)
>     base = "?";
>   return last_component (program_invocation_name);

gnulib-getprogname-fix-errors.diff
Description: Text document