[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/4] New getprogname module
From: |
Jim Meyering |
Subject: |
Re: [PATCH v2 0/4] New getprogname module |
Date: |
Thu, 8 Sep 2016 13:14:08 -0700 |
On Wed, Sep 7, 2016 at 11:05 AM, Jim Meyering <address@hidden> wrote:
> On Wed, Sep 7, 2016 at 10:22 AM, Gisle Vanem <address@hidden> wrote:
>> Jim Meyering wrote:
>>
>>> +# elif HAVE_DECL___ARGV
>>> + return last_component (__argv);
>>
>> This should be:
>> return last_component (*__argv);
>>
>> Or with a bit more care:
>> if (*__argv == NULL)
>> return ("?");
>> return last_component (__argv);
>
> Thanks!
> I fixed that and the copy/paste error mentioned below with a patch in
> your name. Will push after you ACK.
>
>> And in the test:
...
> I've fixed that with a separate patch to make it use EXEEXT.
Gisle ACK'd privately, so I've pushed those two commits.
I have also pushed a grep commit updating it to use these fixed parts of gnulib.
- Re: [PATCH v2 0/4] New getprogname module, (continued)
- Re: [PATCH v2 0/4] New getprogname module, Jim Meyering, 2016/09/06
- Re: [PATCH v2 0/4] New getprogname module, Pino Toscano, 2016/09/06
- Re: [PATCH v2 0/4] New getprogname module, T J, 2016/09/06
- Re: [PATCH v2 0/4] New getprogname module, Pino Toscano, 2016/09/06
- Re: [PATCH v2 0/4] New getprogname module, Jim Meyering, 2016/09/06
- Re: [PATCH v2 0/4] New getprogname module, Gisle Vanem, 2016/09/06
- Re: [PATCH v2 0/4] New getprogname module, Jim Meyering, 2016/09/06
- Re: [PATCH v2 0/4] New getprogname module, Jim Meyering, 2016/09/07
- Re: [PATCH v2 0/4] New getprogname module, Gisle Vanem, 2016/09/07
- Re: [PATCH v2 0/4] New getprogname module, Jim Meyering, 2016/09/07
- Re: [PATCH v2 0/4] New getprogname module,
Jim Meyering <=