[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: getprogname: comments and test failure on Cygwin
From: |
Jim Meyering |
Subject: |
Re: getprogname: comments and test failure on Cygwin |
Date: |
Sun, 16 Oct 2016 07:56:37 -0700 |
On Sun, Oct 16, 2016 at 5:15 AM, Pádraig Brady <address@hidden> wrote:
> On 16/10/16 12:55, Bruno Haible wrote:
>> Hi,
>>
>> The 'getprogname' module test fails on Cygwin 2.6, because the returned
>> value is "test-getprogname", not "test-getprogname.exe". (On mingw, on the
>> other hand, it really is "test-getprogname.exe".)
>>
>> Also, while at it, I'd like to add comments:
>> 1. The declaration in getprogname.h does not state what the function does
>> or return.
>> 2. In getprogname.c it is hard to understand which code is used for which
>> platform.
>> 3. In test-getprogname.c there is no explanation why the file name is
>> compared
>> with strcmp and not strcasecmp.
>
> All improvements look good to me.
Likewise.
Thank you!
- getprogname: comments and test failure on Cygwin, Bruno Haible, 2016/10/16
- Re: getprogname: comments and test failure on Cygwin, Pádraig Brady, 2016/10/16
- Re: getprogname: comments and test failure on Cygwin,
Jim Meyering <=
- Re: getprogname: comments and test failure on Cygwin, Daiki Ueno, 2016/10/18
- getprogname and libtool, Bruno Haible, 2016/10/18
- Re: getprogname and libtool, Daiki Ueno, 2016/10/18
- Re: getprogname and libtool, Jim Meyering, 2016/10/18
- Re: getprogname and libtool, Bruno Haible, 2016/10/18
- Re: getprogname and libtool, Jim Meyering, 2016/10/18
- Re: getprogname and libtool, Bruno Haible, 2016/10/18
- Re: getprogname and libtool, Jim Meyering, 2016/10/18
- Re: getprogname and libtool, Bruno Haible, 2016/10/18
- Re: getprogname: comments and test failure on Cygwin, Jim Meyering, 2016/10/18