Re: quotearg test failures

[Pádraig Brady]

On 16/10/16 17:49, Bruno Haible wrote:
> Hi Pádraig,
> 
> On a glibc system (glibc 2.15, Linux 3.8) I get these test failures
> from a gnulib testdir:
> 
> 1) For module 'quotearg':
> 
> FAIL: test-quotearg.sh
> 
> $ LOCALE=fr_FR.UTF-8 LOCALEDIR=locale ./test-quotearg
> test-quotearg.h:53: assertion 'la == lb' failed
> 
> (gdb) where
> #0  0x00007ffff7a52035 in raise () from /lib/x86_64-linux-gnu/libc.so.6
> #1  0x00007ffff7a5579b in abort () from /lib/x86_64-linux-gnu/libc.so.6
> #2  0x00000000004011a3 in compare (a=0x4063d5 "««\\»»", la=9, b=0x608460 "«a' 
> b»", lb=8) at test-quotearg.h:53
> #3  0x000000000040159f in compare_strings (func=0x401684 
> <use_quotearg_buffer>, results=0x6081e0, ascii_only=false) at 
> test-quotearg.h:91
> #4  0x0000000000401ae3 in main (argc=1, argv=0x7fffffffdb98) at 
> test-quotearg.c:87
> 
> Apparently the quoting result of string "a' b", which ought to have been
> "«a' b»", is now "««\\»»" - which is complete nonsense.
> 
> Can you reproduce this? You must first make sure that you have a fr_FR.UTF-8
> locale on your system. If not, create it using
>   # localedef -i fr_FR -f UTF-8 fr_FR.UTF-8'
> 
> 
> 2) For module 'sh-quote', which relies on 'quotearg':
> 
> FAIL: test-sh-quote
> 
> test-sh-quote.c:48: assertion 'buf[output_len + 1] == '%'' failed
> FAIL test-sh-quote (exit status: 134)
> 
> 
> 3) For module 'system-quote', which relies on 'sh-quote':
> 
> FAIL: test-system-quote.sh
> 
> test-system-quote-main.c:65: assertion 'buf[output_len + 1] == '%'' failed
> FAIL test-system-quote.sh (exit status: 134)
> 
> 
> I suspect the commit that you delivered on 2016-10-03, since that's the only
> recent change in this area. Can you please take a deep look?

The attached should fix up those tests.
Sorry for missing those.

Pádraig.

quotearg-test-fixes.patch
Description: Text Data