[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#23153: [PATCH]: For FIXME in cp.c
From: |
Pádraig Brady |
Subject: |
Re: bug#23153: [PATCH]: For FIXME in cp.c |
Date: |
Wed, 2 Nov 2016 17:59:34 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
unarchive 23153
stop
On 05/04/16 15:49, Rishabh Dave wrote:
> Did fix that - changing function call to GNU style and "suffix_from_env" to
> local variable. The corresponding patch is attached.
>
> On Mon, Apr 4, 2016 at 10:36 PM, Paul Eggert <address@hidden> wrote:
>
>> On 04/04/2016 09:30 AM, Rishabh Dave wrote:
>>
>>> + char *suffix_from_env;
>>> size_t ssize;
>>> bool simple = true;
>>> +
>>> + /* If simple_backup_suffix is '~', check environment if we have any
>>> there. */
>>> + if (strcmp(simple_backup_suffix, "~") == 0)
>>> + if ((suffix_from_env = getenv("SIMPLE_BACKUP_SUFFIX")) != NULL)
>>> + simple_backup_suffix = xstrdup (suffix_from_env);
>>> +
Sorry for the delay.
I'll apply the attached variant to gnulib instead.
That has the property that --suffix=~ will still override
an env variable of SIMPLE_BACKUP_SUFFIX.
It also avoids a redundant malloc, and handles empty env variables.
I'll then apply the coreutils patches in your name.
thanks,
Pádraig
gnulib-backupfile-no-getenv.patch
Description: Text Data
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: bug#23153: [PATCH]: For FIXME in cp.c,
Pádraig Brady <=