Re: The non-recursive-gnulib-prefix-hack module

[Pádraig Brady]

On 07/11/16 02:35, Bruno Haible wrote:
> Hi Pádraig,
> 
>>> lib/gnulib.mk:32: error: required file '$gl_source_base/alloca.c' not found
>>> Makefile.am:226:   'lib/local.mk' included from here
>>> lib/local.mk:1:   'lib/gnulib.mk' included from here
>>> autoreconf: automake failed with exit status: 1
>>> ./bootstrap: autoreconf failed
> ...
>> The issue is in m4/non-recursive-gnulib-prefix-hack.m4
>> There are single quotes around $1 that need to be changed to double quotes.
> 
> This would not help, because at the point when
>   gl_LIBOBJS=`echo "$gl_LIBOBJS" | sed -e 's, , $gl_source_base/,g'`
> is being run, $gl_source_base has the value 'gnulib-tests', not 'lib'.
> 
>> More problematically AC_CONFIG_LIBOBJ_DIR is used there which
>> looks like it needs to be initialized before gl_source_base is set.
> 
> Yes, the statement
>   ac_config_libobj_dir=$gl_source_base
> is also out of order.
> 
>> I'll need to do a lot more digging to figure all that out.
> 
> It's probably not worth to try to fix the non-recursive-gnulib-prefix-hack
> module in this direction. Please feel free to revert my change to
> modules/non-recursive-gnulib-prefix-hack, and add a comment why 'lib' has
> to be hardcoded in this place.

Done.

thanks