bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] support for quarter from strftime (%q)


From: Bruno Haible
Subject: Re: [PATCH] support for quarter from strftime (%q)
Date: Mon, 14 Nov 2016 22:10:59 +0100
User-agent: KMail/4.8.5 (Linux/3.8.0-44-generic; KDE/4.8.5; x86_64; ; )

Hi Pádraig,

> add to strptime()
> also for consistency.  Therefore I did that in the attached,
> added a test, and pushed.

If users of the 'strptime' module should be able to rely on the %q feature,
it requires also a change in doc/posix-functions/strptime.texi and
m4/strptime.m4, modules/strptime, etc. Because so far, on platforms where
strptime exists and does not support %q, this code will *not* override it:
  if test $HAVE_STRPTIME = 0; then
    AC_LIBOBJ([strptime])
    gl_PREREQ_STRPTIME
  fi

Or was it meant to be an undocumented feature? Then the unit test should
be conditionalized.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]