[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mountlist/ptsname_r: leverage AC_HEADER_MAJOR
From: |
Mike Frysinger |
Subject: |
Re: [PATCH] mountlist/ptsname_r: leverage AC_HEADER_MAJOR |
Date: |
Mon, 5 Dec 2016 23:10:07 -0500 |
On 02 Dec 2016 01:40, Bruno Haible wrote:
> Pádraig Brady wrote in
> http://lists.gnu.org/archive/html/bug-gnulib/2016-04/msg00022.html
> and pushed in
> http://lists.gnu.org/archive/html/bug-gnulib/2016-11/msg00116.html:
>
> > Context in
> > http://lists.gnu.org/archive/html/bug-gnulib/2016-03/msg00025.html
> > glibc-2.23 and musl now need this change it seems.
> > The patch should be fine to apply though and fixes an immediate issue.
>
> glibc and musl cannot need a change that only affects the behaviour on
> Solaris, AIX, and OSF/1. => There was no "immediate issue".
>
> Actually the only benefit of the change is that on Solaris, the code now
> uses <sys/mkdev.h> instead of <sys/sysmacros.h>. <sys/mkdev.h> is somewhat
> cleaner (doesn't define unrelated old cruft).
i was just grepping for all users and bulk converting them over. you're
certainly correct in the case of the ptsname_r module, the current code
that calls major/minor isn't used on glibc/musl/etc... systems.
-mike
signature.asc
Description: Digital signature